-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify types on get_parent_class() #1383
Conversation
63c70d3
to
823c7d0
Compare
src/Analyser/TypeSpecifier.php
Outdated
// the is_string() check should not be necessary, since ConstantStringType->getValue() returns 'string' | ||
&& is_string($constantType->getValue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @rvanvelzen, the refactoring might conflict with your existing #1761 PR.
3e7a923
to
e91e1f1
Compare
} | ||
} | ||
|
||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this if block is the only new logic of this PR.
everything else is pre-existing logic which was just factored out into new private methods
fb01d17
to
eae128c
Compare
@ondrejmirtes if we could land this one it would unblock some of the already opened PRs for more TypeSpecifier goodness. |
Thank you. |
closes phpstan/phpstan#5552